Replace ConsumedNoteInfo with Nullifier
#360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @igamigo: this might affect some things in the client, but the changes should be very minor. |
Dominik1999
approved these changes
Dec 15, 2023
bobbinth
force-pushed
the
bobbin-note-nullfier
branch
from
e38fbd4
to
b170069
Compare
Because I've changed both the Rust code and the MASM code to compute the input note has in the same way, the tests don't need to be changed (if I updated only MASM or only Rust, the tests would be failing). |
bobbinth
force-pushed
the
bobbin-note-nullfier
branch
from
b170069
to
afc90bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a part of #350. Specifically, I removed
ConsumedNoteInfostruct and replaced it withNullifier. Using only nullifiers to compute consumed note commitment is sufficient since #283 as the verifier no longer needs to know script roots for the consumed notes.The commitment to consumed notes is still computed as a sequential hash of
(nullifier, ZERO)tuples instead of just as a sequential hash of nullifiers. I kept it this way primarily to keep the scope of changes relatively small and also because we may need to update the logic again to support #353.