Replace TransactionResult with ExecutedTransaction
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
force-pushed
the
bobbin-tx-result
branch
from
879019a to
7a68d49
Compare
Move transaction output parsing to `miden-lib`
Refactor `ProvenTransaction` to reduce code duplication
Reorganize `miden-lib` modules
Move transaction `AdviceInput` construction logic to `miden-lib`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #385.
This PR replaces
TransactionResultstruct withExecutedTransactionstruct (previously, these were kind of redundant). The new struct is actually basically the same as the previousTransactionResult- but I thought thatExecutedTransactionwould be a better name.Also, as a part of this refactoring, I've consolidated most transaction errors - but more refactoring will be done on this in subsequent PRs.