Event-based procedure index lookups #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking into more and more comments I have seen that we have comments starting with a capital letter, others starting with lower case letters. Would be good to have a convention about how to build comments and documentation around the codebase in masm and rs files. |
|
Could you explain to me what the Like |
|
I see the difference between the types and their mocked version, but can you explain to me why do we need them and why do we use them instead of the classical types? |
phklive
approved these changes
Jan 8, 2024
bobbinth
force-pushed
the
bobbin-tx-events
branch
from
783726e
to
ce4b2d8
Compare
bobbinth
force-pushed
the
bobbin-proc-index
branch
from
3fcf698
to
4850dcd
Compare
bobbinth
force-pushed
the
bobbin-proc-index
branch
from
4850dcd
to
ee9b7eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #404 and partially addresses #273. Specifically, we no longer put the
proc_root |-> proc_indexmap into the advice provider. Instead, we introducePushAccountProcedureIndexevent which theTransactionHostuses to populate the advice stack with the index of the relevant procedure.Also, as a part of this PR I updated the tests to use
MockHost- this resulted in quite a few changes in existing tests.