-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event-based procedure index lookups #405
Conversation
Looking into more and more comments I have seen that we have comments starting with a capital letter, others starting with lower case letters. Would be good to have a convention about how to build comments and documentation around the codebase in masm and rs files. |
Could you explain to me what the Like |
I see the difference between the types and their mocked version, but can you explain to me why do we need them and why do we use them instead of the classical types? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Mainly nits, typos and questions.
Code compiles and all tests are green ✅
783726e
to
ce4b2d8
Compare
3fcf698
to
4850dcd
Compare
4850dcd
to
ee9b7eb
Compare
This PR builds on #404 and partially addresses #273. Specifically, we no longer put the
proc_root |-> proc_index
map into the advice provider. Instead, we introducePushAccountProcedureIndex
event which theTransactionHost
uses to populate the advice stack with the index of the relevant procedure.Also, as a part of this PR I updated the tests to use
MockHost
- this resulted in quite a few changes in existing tests.