Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note object refactoring #664

Merged
merged 4 commits into from
May 6, 2024
Merged

Note object refactoring #664

merged 4 commits into from
May 6, 2024

Conversation

bobbinth
Copy link
Contributor

@bobbinth bobbinth commented May 3, 2024 •
edited
Loading

Addresses #645, specifically:

  • Renames NoteEnvelope into NoteHeader.
  • Introduces a new struct NoteDetails which consists of note assets and recipient.
  • Refactors Note struct to be based on NoteHeader and NoteDetails.

@bobbinth bobbinth marked this pull request as ready for review May 6, 2024 05:38
polydez
polydez approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@polydez polydez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@bobbinth bobbinth linked an issue May 6, 2024 that may be closed by this pull request
Note object refactoring #645
Closed
igamigo
igamigo approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I never commented on the issue but I overall agree with this restructuring.

@bobbinth bobbinth merged commit f3bf7ae into next May 6, 2024
9 checks passed
@bobbinth bobbinth deleted the bobbin-note-objects branch May 6, 2024 16:49
@bobbinth bobbinth mentioned this pull request May 6, 2024
Closed
bobbinth added a commit that referenced this pull request May 13, 2024
@bobbinth
refactor: update Note object (#664)
8f83bd6 
* Rename NoteEnvelope into NoteHeader
* Change Note struct to be based on header and details
bobbinth added a commit that referenced this pull request May 14, 2024
@bobbinth
refactor: update Note object (#664)
ff95253 
* Rename NoteEnvelope into NoteHeader
* Change Note struct to be based on header and details
Fumuran pushed a commit that referenced this pull request May 23, 2024
@bobbinth @Fumuran
refactor: update Note object (#664)
5f3bef7 
* Rename NoteEnvelope into NoteHeader
* Change Note struct to be based on header and details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igamigo igamigo igamigo approved these changes

@polydez polydez polydez approved these changes

@Dominik1999 Dominik1999 Awaiting requested review from Dominik1999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Note object refactoring
3 participants
@bobbinth @igamigo @polydez