Tracking PR for v0.6.0 release #850
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
added
the
no changelog
* Updated api.masm with storage_offset and it's application * Ported PR to new VM version * Need to change the mock structure for AdviceMap * storage offset test works * Added AccountCode::mock_specific() * Fixed error with indexes * Change test index number to 255 ( max proc index ) * Test supports setting and getting using offset storage slot * Added changelog * Updated changelog for 0.6.0 * Added some comments + test cleanup * Change naming of procs + added comments + added error * Improve storage offset test + added comments * test: Use transaction executor with offset test (#853) * test: Use transaction executor with offset test * Updated test, added get check * Updated comments
…ion to `AccountStorageMode` feat: add `Display`, `FromStr` and `TryFrom<&str>` implementation to `AccountStorageMode`
…truct to `LocalTransactionProver` (#865) * feat: add TransactionProver trait, rename the TransactionProver struct to LocalTransactionProver * fix: update changelog * fix: add missing maybe_async to prove method * feat: add default for LocalTransactionProver * fix: lint * fix(changelog): merge entries, use past tense
* Updated api.masm with storage_offset and it's application * Ported PR to new VM version * Need to change the mock structure for AdviceMap * storage offset test works * Added AccountCode::mock_specific() * Fixed error with indexes * Change test index number to 255 ( max proc index ) * Test supports setting and getting using offset storage slot * Added changelog * Updated changelog for 0.6.0 * Added some comments + test cleanup * Cargo update * Updated data accessors, added StorageSlotType * miden-tx left to fix * Change naming of procs + added comments + added error * Improve storage offset test + added comments * Added validate_account_storage_slots * test_serde and test_account_storage_slots_commitment fail * test_get_item works * lint * Fixed merging errors * Lint * test_set_item works * docs * test_get_storage_slot_type works * Added storage maps to AdviceProvider + test_get_map_item works * Working on set_item, works internally, account is not modified * Working on set_map_item, set_item works * lint * test_set_map_item works * Added epilogue storage hashing * testing * Epilogue tests working, update_account_storage working * Relaxed bounds for get_item, changed memory location of account procedures to prevent collision, test_storage_offset works * apply delta works * Fixed errors with faucet data not at 0, errors generating signatures * All tests are passing * added changelog * Uncommented forgotten tests, fixing * lint * Reversed account setup and account validation in prologue * Updated bounds + improved doc comments * Cleanup * First review, pass 1 * First review, pass 2 * First review, pass 3, storage_root to storage_commitment * First review, pass 4, storage_root to storage_commitment, more * First review, pass 5 * Revert accounts.md changes + improve storage section * const masts * fix prologue test * Removed bound checks from kernel * Changed comments from FIX to TOTO see miden-vm/#1122 * Requested changes
* Made requested changes, added max and actual info to errors + helper fn * Restore num_storage_slot indexing
* refactor: reduce note tree depths, don't store note's id/metadata in note tree * docs: update CHANGELOG.md * refactor: small code improvement * format: reformat using rustfmt * fix: return back `NOTE_LEAF_DEPTH` constant * refactor: use `NoteId` instead of digest in `BlockNoteTree` constructor * refactor: address review comments * fix: move validation to constructor of `BlockNoteIndex` * feat: implement `leaf_index_value` method in `BlockNoteIndex` * fix: check in `BlockNoteIndex` * fix: `MAX_NOTES_PER_BATCH` calculation * refactor: make assert expression cleaner
* Added AccountStorageHeader * Change . to , in comment * Updated changelog * Add get_header to AccountStorage + AccountStorageHeader methods * Added assert! and comment * No need to reference the struct in doc comments * chore: minor doc improvements --------- Co-authored-by: Bobbin Threadbare <[email protected]>
* feat: Set transaction recency conditions * Correctly build stack outputs for verifier * Format correctly
* refactor: move `MAX_NUM_FOREIGN_ACCOUNTS` into `miden-objects` * docs: update `CHANGELOG.md`
* Change storage_offset from u16 to u8 * Added storage size to AccountCode and AccountProcInfo * Updated authenticate_procedure and get_procedure_info to support storage_size * Remove unwanted changes * Added validate_storage_sizes * Fix masm typo * Errors since changes * Fixed api.masm * executed_transaction_account_delta errors out * executed_transaction_account_delta works * All tests are passing * updated changelog * Move storage valdation logic to new accounts * Added storage size and offset check on AccountProcedureInfo creation * Lint * Merge validate offsets and sizes * Improved doc comments + Changed panic to Error * Fix no-std * Add Errors, re-organize felts, improve namings
* Implement maybe_async_trait * Clippy temporary fix * CHANGELOG * Go back to published winter-maybe-async (0.10.1) * Format new generated files * Address reviews * Impl Send+Sync for TransactionContext * Format
* feat(lib): Rework error messages and names * feat(tx): Generate tx kernel constants * chore: Rename error constants in tests and format * chore: Add changelog entry * feat(tx): Include all errors in `asm` dir, group errors by category * chore: Rename newly added error and regenerate vm errors * feat(tx): Check for duplicate error codes * chore: Rename back to tx kernel errors
* feat: Make TransactionProver maybe_async_trait * chore: format
* chore: Add changelog entry * feat(objects): Rework and optimize asset serialization * feat(objects): Fix Deserializable for Non Fungible Asset
* feat: Add features to prover service * feat: Prover service name rollback * Update README.md
* feat: export expiration procedure for wallet and faucet * refactor: rename `update_expiration_block_num` to `update_expiration_delta` * Clear the stack * Test fix * revert name change * feat: export `get_expiration_block_delta` * docs: add docs for exposed procedures * refactor: rename user-facing procedure * fix: address suggestions --------- Co-authored-by: igamigo <[email protected]>
* feat: connect lazily on prove * chore: update CHANGELOG * feat: create separate makefile install command for testing * fix: wasm build * feat: mantain connection between prove calls * fix: remove new line * fix: address suggestions * fix: update makefile doc comment --------- Co-authored-by: Bobbin Threadbare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tracking PR for v0.6.0 release.