-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set to 1
all faucet account storage offsets
#875
Conversation
84bb4d9
to
55298ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Not a full review yet (I haven't yet looked at MASM code), but I left a few comments inline. The main one is the question about needing to add location
parameter for slot additions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I reviewed all non-test code (and some test code as well), and left some more comments inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Missing some context for the MASM changes, but the code looks good. Left some minor comments.
EDIT: For some reason the comments did not show up (because I started reviewing before the newest commit?), adding them right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
In this PR I propose to set to 1 all procedures storage offsets of faucet accounts.
Closes: #864 and #863