Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Factor out note scripts #880

Merged
merged 4 commits into from
Sep 19, 2024
Merged

refactor: Factor out note scripts #880

merged 4 commits into from
Sep 19, 2024

Conversation

igamigo
Copy link
Collaborator

@igamigo igamigo commented Sep 17, 2024

Factoring out note scripts so that they can be accessed separately. This way, for example, users can get the script root without having to create a note first.
Also moves one helper function to the previously-existing utils mod.

Copy link
Collaborator

@tomyrd tomyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit c1ecf56 into next Sep 19, 2024
8 checks passed
@bobbinth bobbinth deleted the igamigo-note-scripts branch September 19, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants