Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add kernel root to Block::mock() #883

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: Add kernel root to Block::mock() #883

merged 1 commit into from
Sep 17, 2024

Conversation

igamigo
Copy link
Collaborator

@igamigo igamigo commented Sep 17, 2024 •
edited
Loading

To correctly mock functional blocks we'd need this. Tests that rely on mocked blocks on the client would fail otherwise.

@igamigo igamigo added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Sep 17, 2024
@igamigo igamigo marked this pull request as ready for review September 17, 2024 20:06
bobbinth
bobbinth approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

tomyrd
tomyrd approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@tomyrd tomyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests work on my machine correctly

@igamigo igamigo merged commit adc6626 into next Sep 17, 2024
8 checks passed
@igamigo igamigo deleted the igamigo-try-fix branch September 17, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomyrd tomyrd tomyrd approved these changes

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
no changelog This PR does not require an entry in the `CHANGELOG.md` file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igamigo @tomyrd @bobbinth