Add storage bounds to account procedures #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Oct 2, 2024
bobbinth
approved these changes
Oct 5, 2024
Comment on lines
+400
to
+405
| # assert that if size is 0 then offset is 0 | ||
| dup.1 eq.0 | ||
| if.true | ||
| dup eq.0 assert.err=ERR_INVALID_STORAGE_OFFSET_FOR_SIZE | ||
| end | ||
| # => [storage_offset, storage_size, index, num_storage_slots, num_account_procedures] |
There was a problem hiding this comment.
Let's add a TODO for this block to figure out how to do this without the if statement.
There was a problem hiding this comment.
Why would we need to remove the if statement?
There was a problem hiding this comment.
if statements are relatively expensive. So, if we can do this with some small number (e.g., half a dozen or so) non-conditional instructions, this would be quite a bit more efficient.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I propose to add storage bounds to account procedures this will prevent a procedure from accessing unauthorised storage slots.
We have added a lower bound in the
storage_offsetbut no upper bound. This pr addsstorage_sizewhich will be the upper bound for any account code procedure.Closes: #866