Removed unnecessary EMPTY_STORAGE_MAP_ROOT const
#916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polydez
changed the title
EMPTY_STORAGE_MAP_ROOT constEMPTY_STORAGE_MAP_ROOT const
Mirko-von-Leipzig
approved these changes
Oct 11, 2024
bobbinth
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Thank you! Overall, the changes look fine, but I'm not sure I understand the motivation behind the change. It seems to me that having a single constant is a bit better than using EmptySubtreeRoots::entry(StorageMap::STORAGE_MAP_TREE_DEPTH, 0) in a couple of places.
Ideally, we'd set this constant as:
pub const EMPTY_STORAGE_MAP_ROOT: Word = EmptySubtreeRoots::entry(StorageMap::STORAGE_MAP_TREE_DEPTH, 0);But I'm not sure if that's possible.
polydez
force-pushed
the
polydez-remove-unnecessary-const
branch
from
ae9f924
to
e1140b2
Compare
Yes, it's possible, please take a look! |
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we remove unnecessary
EMPTY_STORAGE_MAP_ROOTconstant in favor of usingEmptySubtreeRoots::entry()method frommiden-crypto.