Remove num_procs from account procedure data
#923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fumuran
added
the
no changelog
PhilippGackstatter
approved these changes
Oct 15, 2024
miden-lib/src/transaction/inputs.rs
Outdated
Comment on lines
186
to
187
| // extend the advice map with the account code data and number of procedures | ||
| let mut procedures: Vec<Felt> = vec![(code.num_procedures() as u8).into()]; | ||
| procedures.append(&mut code.as_elements()); | ||
| inputs.extend_map([(code.commitment(), procedures)]); | ||
| inputs.extend_map([(code.commitment(), code.as_elements())]); |
There was a problem hiding this comment.
Nit: The comment still mentions the number of procedures - could be updated.
There was a problem hiding this comment.
Ops, my bad, I overlooked it. Thank you!
bobbinth
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Looks good! Thank you!
The only thing that I noticed is that we should probably also update doc comments for the prologue's main procedure (here). It seems like the advice map part is missing entries for both procedures and storage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR changes the value in the advice map corresponding to the account code commitment.
Similar to the account storage data, the number of procedures was removed from the data provided to the advice map. Now the number of account procedures is computed from the number of field elements used to represent the procedure data.