Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make structs Send + Sync, lazily initialize scripts #939

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

igamigo
Copy link
Collaborator

@igamigo igamigo commented Oct 28, 2024

Closes #909.
Closes #377.

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a couple of small comments inline. Once these are addressed, let's make sure that these changes don't break anything on the client side (especially for the web client).

miden-lib/src/notes/scripts.rs Outdated Show resolved Hide resolved
miden-lib/src/notes/scripts.rs Outdated Show resolved Hide resolved
miden-lib/src/notes/mod.rs Outdated Show resolved Hide resolved
@igamigo
Copy link
Collaborator Author

igamigo commented Oct 29, 2024

@tomyrd was able to test this set of changes with the client's integration tests (including web client), so should be good to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants