Improve store and state sync #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
requested changes
Dec 22, 2023
bobbinth
approved these changes
Dec 27, 2023
src/client/sync_state.rs
Outdated
Comment on lines
105
to
109
| fn get_newly_committed_note_hashes( | ||
| &self, | ||
| notes: &[NoteSyncRecord], | ||
| block_header: &BlockHeader, | ||
| ) -> Result<Vec<(Digest, NoteInclusionProof)>, ClientError> { |
There was a problem hiding this comment.
nit: the name of the function can probably be improved since we are not really getting note hashes here. Maybe something like get_newly_committed_note_info.
Also, would be great to add some brief doc comments to this function to explain what it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RecordedNoteas well asNotes, in order to be able to track notes after transaction execution and update the notes with their respective inclusion proofs on state syncAccountStorageis stored in place of the slots in order to be able to reconstructAccountfor theDataStore