Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include_str broken in certain build configurations #3

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix: include_str broken in certain build configurations #3

merged 1 commit into from
Mar 22, 2024

Conversation

bitwalker
Copy link
Contributor

This should fix the document build so that it works both with cargo doc and cargo publish, at least it does locally for me. I think this should fix the docs on docs.rs as well.

@bitwalker bitwalker merged commit 162c606 into main Mar 22, 2024
12 checks passed
@bitwalker
Copy link
Contributor Author

@bobbinth The 0.1.0 package is broken, and needs to be yanked. This PR fixes the issue, but we'll need to publish a new patch release with it included

@bitwalker bitwalker deleted the bitwalker/doc-fix branch March 22, 2024 17:02
bobbinth
bobbinth reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for fixing this!

I'll publish v0.1.1 shortly.

@bobbinth
Copy link
Contributor

v0.1.1 is now on crates.io and the docs are building fine. Thank you!

@bitwalker
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitwalker @bobbinth