Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Correctly emit traces on faucet #499

Open
igamigo opened this issue Sep 17, 2024 · 1 comment
Open

[Task]: Correctly emit traces on faucet #499

igamigo opened this issue Sep 17, 2024 · 1 comment
Labels
good first issue Good for newcomers
Milestone

Comments

@igamigo
Copy link
Collaborator

igamigo commented Sep 17, 2024

Node's components affected by this task

Faucet

What should be done?

On the faucet, when any error occurs on the server's actions, it is not logged correctly to the console. Instead, errors are bubbled up as Result<_,_>, and absorbed in the top level. Instead, it should be logged as an error trace.

How should it be done?

On the endpoint functions, make sure that if any error is returned, it is logged and shown pertinently.

When is this task done?

When, for example, we can see internal server errors on the console.

Additional context

#498 (comment)

@Mirko-von-Leipzig
Copy link
Contributor

Mirko-von-Leipzig commented Oct 8, 2024

This has likely been fixed in the migration from actix to axum in #479.

It now uses tower's http-trace which has sensible defaults and I presume logs failures.

I would keep this issue open as we may want to improve the traces further by customizing them.

The axum tracing example shows some things we may want to include, like the rejection of extractors (we use the Json<T> extractor for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

3 participants