-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): GetNoteAuthenticationInfo
endpoint
#421
Conversation
ee7efd8
to
27f421b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good. This is not a full review yet - but I left a couple of comments inline. The main one is that note inclusion proof is actually a bit more complex than just a single Merkle path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good. Not a full review but I did leave some comments inline. The main one is I think just NoteInclusionProof
objects are not sufficient we are missing the MMR part of the proofs.
GetNoteInclusionProofs
endpoint in both Store and RPCGetNoteInclusionProofs
endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left some comments inline (and I think answered all outstanding questions - but let me know if I missed something).
34f46ab
to
4e8f9c4
Compare
4e8f9c4
to
4e6a05e
Compare
e8034ec
to
138d8c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased and I think did the block producer portion as well.
proto/responses.proto
Outdated
message GetNoteInclusionProofsResponse { | ||
note.NoteInclusionProofs proofs = 1; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming feels weird. Elsewhere in the comments there was a NoteAuthenticationInfo
suggestion, which I have used in parts of the code. I've gotten a bit lost wrt to the naming - should NoteInclusionProofs
become NoteAuthenticationInfo
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - I think I suggested it somewhere. I think NoteAuthenticationInfo
may be a bit better (one reason is that we use it in the context of authenticating "unauthenticated notes") - but also not a strong preference by any means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made this change -- should the proto method name change as well to GetNoteAuthenticationInfo
?
I'm still a bit murky on the nomenclature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could go either way - so, basically, up to you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed it so that it isn't the only outlier :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left a few small comments inline. Once these are addressed, we can merge.
I also left one comment for a subsequent PR. I think we should do it right after this PR (it shouldn't be too complex).
GetNoteInclusionProofs
endpointGetNoteAuthenticationInfo
endpoint
Resolves: #395
This PR adds
GetNoteAuthenticationInfo
endpoint. Prior this we had to useGetNotesById
endpoint for getting inclusion proofs, but it returns a lot of unnecessary information for such task.Also
GetBlockInputs
endpoint now returns not only found requested note IDs, but also their inclusion proofs.