Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting debug mode via CLI #1322

Closed
hackaugusto opened this issue Apr 30, 2024 · 6 comments
Closed

Allow setting debug mode via CLI #1322

hackaugusto opened this issue Apr 30, 2024 · 6 comments
Labels
good first issue Good for newcomers

Comments

@hackaugusto
Copy link
Contributor

Task

Add a flag to the run command which enables the assembler debug mode.

@bobbinth
Copy link
Contributor

bobbinth commented May 1, 2024

We already debug mode in CLI (see here). Or did you mean something else?

@hackaugusto
Copy link
Contributor Author

Yeah, I was thinking of the run command and getting the debug.stack working for it.

@bobbinth
Copy link
Contributor

bobbinth commented May 9, 2024

Ah - I missed that this was specifically for the run command. Yes, I think adding something like --debug is a good idea (would be similar to --tracing flag that we already have).

@bobbinth bobbinth added the good first issue Good for newcomers label Aug 7, 2024
@yasonk
Copy link

yasonk commented Sep 5, 2024

Would this --debug argument be passed into the command like this after building?

./target/optimized/miden run -a miden/examples/nprime/nprime.masm --debug

Why not just do this?

./target/optimized/miden debug -a miden/examples/nprime/nprime.masm

This seems to already support debug.stack
An example would help potentially.

@bobbinth
Copy link
Contributor

bobbinth commented Sep 5, 2024

Would this --debug argument be passed into the command like this after building?

./target/optimized/miden run -a miden/examples/nprime/nprime.masm --debug

Yes, that's how I was thinking it would work.

Why not just do this?

./target/optimized/miden debug -a miden/examples/nprime/nprime.masm

This command would start an interactive debugger and then the user would be able to step through the execution. The two approaches are similar but the interactive debugger is quite a bit heavier and may not be needed in all cases.

@yasonk yasonk mentioned this issue Sep 17, 2024
5 tasks
@bobbinth
Copy link
Contributor

Closed by #1502.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants