-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug mode via cli option #1502
Debug mode via cli option #1502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for doing this! This is not a full review, but I left a few comments inline.
.PHONY: test-package | ||
test-package: ## Tests specific package: make test-package package=miden-vm | ||
$(DEBUG_ASSERTIONS) cargo nextest run --cargo-profile test-release --features testing -p $(package) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A question: would we achieve the same result if we add executable
feature? e.g.,:
$(DEBUG_ASSERTIONS) cargo nextest run --cargo-profile test-release --features testing,executable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing that I added will run the integration tests for just one package as a convenience to avoid having to run all packages. Adding feature "executable" is required to run the unit tests inside the binary crate of miden-vm
package. I created issue #1501 with the question regarding whether adding "executable" is the right way fix the problem of unit tests in miden-vm
not running when using make tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you! I left a couple more small comments inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good! Thank you! I fixed the merge conflict and will merge as soon as CI is green.
Describe your changes
This will introduce
--debug
flag to therun
command in the CLI as described in issue #1322.Includes the following tangental changes:
StackInputs::default()
instead ofDefault::default()
)Issues found
The unit tests in the
miden-vm
package don't run when executingmake test
. Documented in the issue #1501. Ran the unit tests manually.Checklist before requesting a review
next
according to naming convention.