Migrate to using Winterfell 0.7 #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Oct 24, 2023
bobbinth
force-pushed
the
al-migrate-winterfell
branch
from
e3680bd
to
1841ca1
Compare
bobbinth
force-pushed
the
al-migrate-winterfell
branch
from
043d039
to
da70f51
Compare
bobbinth
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
As the title says though probably does not include the best way to use the
AcceptableOptionargument.I also had to make on modification to the
clitest as well as some changes to the MMR tests as well. Probably the problems forcing those changes were due to some rebasing issues.Checklist before requesting a review
nextaccording to naming convention.