Add get_module_ast(path) method to the Library trait
#1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Oct 26, 2023
assembly/src/library/mod.rs
Outdated
Comment on lines
45
to
46
| /// Returns the AST of the module stored at the provided path. | ||
| fn get_module_ast(&self, path: &LibraryPath) -> Option<ModuleAst>; |
There was a problem hiding this comment.
Can we return Option<&ModuleAst> from here? This way, we can avoid cloning modules (which may be a bit expensive).
Also, should we provide a default implementation of this method - i.e., something like:
self.modules()
.iter()
.find(|&module| module.path == *path)
.map(|module| module.ast)
bobbinth
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Looks good! Thank you! Before merging this PR could you check if this will break anything in Miden base? (I think it might as we have another library defined there). If so, then let's create a PR there with the fix and then we'll merge both one right after another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
get_module_ast(path: LibraryPath)method to theLibrarytrait.This method returns an instance of
ModuleAststored in the Library at the providedLibraryPath.