Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build after SimpleSmt change in miden-crypto #1200

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Jan 17, 2024

Fixes build after 0xPolygonMiden/crypto#245

@plafer plafer requested a review from bobbinth January 17, 2024 17:25
core/Cargo.toml Outdated
@@ -23,7 +23,7 @@ std = ["miden-crypto/std", "math/std", "winter-utils/std"]
[dependencies]
math = { package = "winter-math", version = "0.7", default-features = false }
# miden-crypto = { package = "miden-crypto", version = "0.8", default-features = false }
miden-crypto = { package = "miden-crypto", git = "https://github.com/0xPolygonMiden/crypto", branch= "next", default-features = false }
miden-crypto = { package = "miden-crypto", git = "https://github.com/0xPolygonMiden/crypto", branch= "plafer-smt-trait", default-features = false }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to revert this

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you! I'll make a corresponding PR in miden-base later today.

Let's plan to merge this tomorrow.

@bobbinth bobbinth merged commit 0752ec6 into next Jan 18, 2024
15 checks passed
@bobbinth bobbinth deleted the plafer-fix-build-smt branch January 18, 2024 21:14
bobbinth pushed a commit that referenced this pull request Feb 26, 2024
* change branch for miden-crypto
* fix breaking changes
* fix cli
* fix miden-crypto branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants