Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogUp-GKR tracking PR #1365

Closed
wants to merge 39 commits into from
Closed

LogUp-GKR tracking PR #1365

wants to merge 39 commits into from

Conversation

bobbinth
Copy link
Contributor

This is a tracking PR for the LogUp GKR work. The plan right now is:

  • Get the end-to-end process working.
  • Move all generic code to Winterfell (probably for Winterfell v0.10.0 release).
    • At this point we should finalize the public interface for LogUp-GKR in Winterfell.
  • Update this branch to use the new release of Winterfell.

Al-Kindi-0 and others added 30 commits March 22, 2024 19:41
refactor: serialize usize with write_usize (#1266)
* change prover

* change verifier

* cleanup

* Remove `VirtualBusVerifier`

* Remove `VirtualBusProver`

* reorganize exports

* `LayerGatesInputs`

* use constant

* docstrings

* add TODO

* remove TODO

* clippy

* add static_assertions

* add padding comment

* add back `claim` in verifier
Al-Kindi-0 and others added 9 commits May 24, 2024 08:31
* `ProjectiveCoordinates`

* Refactor `LayerGatesInputs`

* FractionalSumCircuit2 WIP

* Use `FractionalSumCircuit2` in prover

* SumCheckProverError

* fix number of layers computed

* SumCheckVerifierError

* Remove old `FractionalSumCircuit`

* Remove old `LayerGatesInputs`

* Remove `CircuitGateInputs`

* Document and rename

* docs

* Document `ProjectiveCoordinates`

* sumcheck_round variable ordering

* fix direction of sum-check

* Simplify and clean up (#1347)

* wip: change terminology of circuit eval

* wip: remove left/right num/denom

* chore: remove static

* chore: remove old file and comments

* Document `project_lower_variable`

* chore: minor nits and renaming

---------

Co-authored-by: Philippe Laferriere <[email protected]>

* add TODOP

* Use `Wire` terminology

* Remove `CompositionPolynomial::num_variables()`

* fix capacity

* rename `NUM_WIRES_PER_TRACE_ROW` constant

* TODOP

* Introduce `reduce_layer_claim`

* use left/right terminology in GkrCompositionMerge

* adjust TODOP

* fix docs

* docs

* clippy

* clippy

* cleanup prove_before_final_circuit_layers loop

No longer uses an index

* adjust docs

* fmt

* doc nit

* nodes -> wires

* doc nit

* cleanup doc

* document loop

* fmt

---------

Co-authored-by: Al-Kindi-0 <[email protected]>
@bobbinth bobbinth changed the base branch from next to logup-gkr2 June 26, 2024 06:05
@plafer
Copy link
Contributor

plafer commented Jun 26, 2024

Closing in favor of #1367

@plafer plafer closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants