-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LogUp GKR #1366
Merged
Merged
LogUp GKR #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: serialize usize with write_usize (#1266)
* change prover * change verifier * cleanup * Remove `VirtualBusVerifier` * Remove `VirtualBusProver` * reorganize exports * `LayerGatesInputs` * use constant * docstrings * add TODO * remove TODO * clippy * add static_assertions * add padding comment * add back `claim` in verifier
* `ProjectiveCoordinates` * Refactor `LayerGatesInputs` * FractionalSumCircuit2 WIP * Use `FractionalSumCircuit2` in prover * SumCheckProverError * fix number of layers computed * SumCheckVerifierError * Remove old `FractionalSumCircuit` * Remove old `LayerGatesInputs` * Remove `CircuitGateInputs` * Document and rename * docs * Document `ProjectiveCoordinates` * sumcheck_round variable ordering * fix direction of sum-check * Simplify and clean up (#1347) * wip: change terminology of circuit eval * wip: remove left/right num/denom * chore: remove static * chore: remove old file and comments * Document `project_lower_variable` * chore: minor nits and renaming --------- Co-authored-by: Philippe Laferriere <[email protected]> * add TODOP * Use `Wire` terminology * Remove `CompositionPolynomial::num_variables()` * fix capacity * rename `NUM_WIRES_PER_TRACE_ROW` constant * TODOP * Introduce `reduce_layer_claim` * use left/right terminology in GkrCompositionMerge * adjust TODOP * fix docs * docs * clippy * clippy * cleanup prove_before_final_circuit_layers loop No longer uses an index * adjust docs * fmt * doc nit * nodes -> wires * doc nit * cleanup doc * document loop * fmt --------- Co-authored-by: Al-Kindi-0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.