Optimize truncate_stack procedure #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
approved these changes
Jul 8, 2024
|
Also - let's update the changelog. And a question: do we already have good tests covering this procedure? |
|
In the changelog should I write about change in cycle count and number of locals? I think that tests for this procedure are fairly decent: we have both basic test and a proptest here. |
I would just say something like "Optimized |
Fumuran
force-pushed
the
andrew-optimize-truncate-stack
branch
from
808deb3
to
68464f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR changes the implementation of the
sys::truncate_stackprocedure in thestdlibto make it more efficient, as it was described in the related issue: #1334.