Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increment all crates version to v0.10.0 #1414

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Conversation

greenhat
Copy link
Contributor

This PR increments all crates versions to v0.10.0 so that compiler crates be able to reference next published VM crates to test the compiler crates publishing.

@greenhat greenhat added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Jul 26, 2024
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@greenhat greenhat marked this pull request as ready for review July 26, 2024 08:12
@greenhat greenhat added no changelog This PR does not require an entry in the `CHANGELOG.md` file and removed no changelog This PR does not require an entry in the `CHANGELOG.md` file labels Jul 26, 2024
@greenhat
Copy link
Contributor Author

I cannot figure out why changelog GA is red. I've restarted the failed job multiple times, checked the script, re-applied the label.

@bobbinth
Copy link
Contributor

I cannot figure out why changelog GA is red. I've restarted the failed job multiple times, checked the script, re-applied the label.

I think we need to add labeled and unlabeled triggers to the CI jobs so that applying labels after a PR is created takes effect - 0xPolygonMiden/miden-node#416 (comment) has more info on this.

@bobbinth bobbinth merged commit 8a5497e into next Jul 27, 2024
9 checks passed
@bobbinth bobbinth deleted the greenhat/bump-to-v-0-10 branch July 27, 2024 08:00
@greenhat
Copy link
Contributor Author

I cannot figure out why changelog GA is red. I've restarted the failed job multiple times, checked the script, re-applied the label.

I think we need to add labeled and unlabeled triggers to the CI jobs so that applying labels after a PR is created takes effect - 0xPolygonMiden/miden-node#416 (comment) has more info on this.

I see. FWIW, I added the label after I created the PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This PR does not require an entry in the `CHANGELOG.md` file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants