Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: verify fix for #1377 #1437

Merged
merged 1 commit into from
Aug 7, 2024
Merged

test: verify fix for #1377 #1437

merged 1 commit into from
Aug 7, 2024

Conversation

bitwalker
Copy link
Contributor

Closes #1377

@bitwalker bitwalker added the tests Related to tests label Aug 7, 2024
@bitwalker bitwalker requested a review from bobbinth August 7, 2024 16:23
@bitwalker bitwalker self-assigned this Aug 7, 2024
@bitwalker bitwalker added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Aug 7, 2024
bobbinth
bobbinth approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a couple of non-blocking nits inline.

assembly/src/tests.rs Show resolved Hide resolved
assembly/src/tests.rs Show resolved Hide resolved
@bobbinth bobbinth merged commit cec3309 into next Aug 7, 2024
9 of 10 checks passed
@bobbinth bobbinth deleted the bitwalker/issue1337-test branch August 7, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees

@bitwalker bitwalker

Labels
no changelog This PR does not require an entry in the `CHANGELOG.md` file tests Related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bitwalker @bobbinth