-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict the number of stack inputs and outputs to 16 #1456
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
467b2fc
refactor: limit input and output stack to 16 elements
Fumuran c6ac62a
1/2 feat: implement new error to check stack overflow
Fumuran 096526c
2/2 feat: implement new error to check stack overflow
Fumuran 191fa31
chore: update comments to fix clippy errors
Fumuran dd9f54a
refactor: code optimizations, renamings, minor improvements
Fumuran 414a7c2
refactor: rename constant, impl deref for stacks
Fumuran 5736aa2
refactor: update test-utils: use local truncate_stack proc
Fumuran 4ea0ac0
refactor: fix bug in ser/de of inputs and outputs, add tests
Fumuran 3331814
Merge branch 'next' into andrew-limit-io-stack-to-16
plafer 4fe1f70
Remove `p1` check of last row
plafer 6c1cd08
refactor: fix overlooked tests
Fumuran fde47d0
chore: update tests, improve docs
Fumuran a0e1076
refactor: rename felt_array_to_ints into() felt_slice_to_ints()
bobbinth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also remove
processor::stack::aux_trace::AuxTraceBuilder::init_responses()
(the default implementation inAuxColumnBuilder
is now sufficient).I also think this means we can get rid of both fields in that
AuxTraceBuilder
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we can actually fully remove the definition, since it has an implementation in the trait directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, we can just use the default implementation, indeed.