Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uniqueness invariant from MastForestBuilder #1473

Merged
merged 57 commits into from
Sep 4, 2024
Merged

Remove uniqueness invariant from MastForestBuilder #1473

merged 57 commits into from
Sep 4, 2024

Commits on Aug 27, 2024

  1. Assembler::invoke: no longer returns an Option

    @plafer
    plafer committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6523811 View commit details
    Browse the repository at this point in the history

  2. MastForestBuilder: ensure_node -> add_node

    @plafer
    plafer committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    4c77063 View commit details
    Browse the repository at this point in the history

  3. Library: use MastNodeId as unique identifier for procedures

    @plafer
    plafer committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    bc5cb74 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. fix tests

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7272a55 View commit details
    Browse the repository at this point in the history

  2. add failing test

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    725eff5 View commit details
    Browse the repository at this point in the history

  3. use MastNodeId to identify procedures in ModuleGraph

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    62b4c52 View commit details
    Browse the repository at this point in the history

  4. ProcedureInfo: store body_node_id

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    72a7093 View commit details
    Browse the repository at this point in the history

  5. ResolvedProcedure: store body_id when present

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    30d2933 View commit details
    Browse the repository at this point in the history

  6. create a new root node on exec

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c678944 View commit details
    Browse the repository at this point in the history

  7. Revert "ProcedureInfo: store body_node_id" 

    This reverts commit 72a7093.
    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    a352fa2 View commit details
    Browse the repository at this point in the history

  8. fix build after ProcedureInfo revert

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    5ae4fd5 View commit details
    Browse the repository at this point in the history

  9. Remove ResolvedProcedure::BodyNodeId

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    de51e2c View commit details
    Browse the repository at this point in the history

  10. Assembler::resolve_target returns Either<MastNodeId, RpoDigest>

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    03471eb View commit details
    Browse the repository at this point in the history

  11. fix failing test

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    bc045b6 View commit details
    Browse the repository at this point in the history

  12. fmt

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    67a061a View commit details
    Browse the repository at this point in the history

  13. add back map digest -> GID to mast forest builder

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    a3c5d8c View commit details
    Browse the repository at this point in the history

  14. MastForestBuilder: change all ensure_* to add_*

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b45d459 View commit details
    Browse the repository at this point in the history

  15. fix regression

    @plafer
    plafer committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    961d6f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. fix failing test

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    a4cb422 View commit details
    Browse the repository at this point in the history

  2. changelog

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0665cf5 View commit details
    Browse the repository at this point in the history

  3. docs

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    ef307c2 View commit details
    Browse the repository at this point in the history

  4. docs

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    cccf018 View commit details
    Browse the repository at this point in the history

  5. add test ensure_unique_node_ids_for_identical_procedures

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    883356a View commit details
    Browse the repository at this point in the history

  6. cleanup MastForestBuilder

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    ecec03b View commit details
    Browse the repository at this point in the history

  7. remove ensure_unique_node_ids_for_identical_procedures test

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    aa04649 View commit details
    Browse the repository at this point in the history

  8. MastForestBuilder::eq_hash()

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    72a482b View commit details
    Browse the repository at this point in the history

  9. MastForestBuilder: digest -> mast_root

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    e18c4e7 View commit details
    Browse the repository at this point in the history

  10. MastForestBuilder: don't duplicate equal nodes

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    4a46d32 View commit details
    Browse the repository at this point in the history

  11. revert changes to tests

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    d959dd6 View commit details
    Browse the repository at this point in the history

  12. invoke: don't create new node needlessly

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    187db6b View commit details
    Browse the repository at this point in the history

  13. fix test

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    53003b5 View commit details
    Browse the repository at this point in the history

  14. fix docs

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    126931e View commit details
    Browse the repository at this point in the history

  15. fmt

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    45539ed View commit details
    Browse the repository at this point in the history

  16. cleanup Assembler::invoke

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    ded33b4 View commit details
    Browse the repository at this point in the history

  17. remove stale TODOs

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c5e6b8b View commit details
    Browse the repository at this point in the history

  18. fix doc tests

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    485cbc8 View commit details
    Browse the repository at this point in the history

  19. fix no_std

    @plafer
    plafer committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    191404a View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. TestContext: don't use debug mode by default

    @plafer
    plafer committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    5b3285e View commit details
    Browse the repository at this point in the history

  2. fix asmop hash

    @plafer
    plafer committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f141c76 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Remove redundant comments

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    8dd1662 View commit details
    Browse the repository at this point in the history

  2. revert comment change

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ca2d6d1 View commit details
    Browse the repository at this point in the history

  3. fix docstring

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    1b619e6 View commit details
    Browse the repository at this point in the history

  4. Library::new(): check that every procedures are indeed exports

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a30a9c7 View commit details
    Browse the repository at this point in the history

  5. rename procedure_root_digest

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3b280f1 View commit details
    Browse the repository at this point in the history

  6. fix docs

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    41f45d4 View commit details
    Browse the repository at this point in the history

  7. refactor Assembler::resolve_target()

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ed09c6c View commit details
    Browse the repository at this point in the history

  8. split Assembler::get_proc_root_id_from_mast_root

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2125923 View commit details
    Browse the repository at this point in the history

  9. Assembler::resolve_target docstring

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    d294d20 View commit details
    Browse the repository at this point in the history

  10. fmt

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    43185ec View commit details
    Browse the repository at this point in the history

  11. invoke: document

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    4c139bb View commit details
    Browse the repository at this point in the history

  12. fmt

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    dd72f68 View commit details
    Browse the repository at this point in the history

  13. add unwrap() comment

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    72b9fe5 View commit details
    Browse the repository at this point in the history

  14. fmt

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    8243fa2 View commit details
    Browse the repository at this point in the history

  15. adjust Assembler::invoke() comment

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    4eeeb03 View commit details
    Browse the repository at this point in the history

  16. fix Assembler::ensure_valid_procedure_mast_root

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2ffd050 View commit details
    Browse the repository at this point in the history

  17. cleanup proc alias

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9b74a8b View commit details
    Browse the repository at this point in the history

  18. fmt

    @plafer
    plafer committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    245022e View commit details
    Browse the repository at this point in the history