Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block hash table #1509

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix block hash table #1509

merged 1 commit into from
Sep 24, 2024

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Sep 23, 2024

Fixes the block hash table.

Note that the block stack table also seems broken (which is why I didn't add a debug_assert_eq! statement for p1). I will fix it in a subsequent PR.

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for fixing these! I left a couple of questions/comments inline.

docs/src/design/decoder/constraints.md Outdated Show resolved Hide resolved
docs/src/design/decoder/constraints.md Outdated Show resolved Hide resolved
docs/src/design/decoder/constraints.md Show resolved Hide resolved
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit 8e9fe06 into next Sep 24, 2024
9 checks passed
@bobbinth bobbinth deleted the plafer-fix-block-hash-table branch September 24, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants