Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block stack table respan #1512

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Sep 25, 2024

There was still a bug after #1511 with how the a RESPAN operation fetches the is_loop virtual column of the block stack table.

The fix is to set is_loop to ZERO when removing a row from a RESPAN, since the is_loop flag (read in hasher_state[5]) only applies to the END operation. For requests, it will only be set for the LOOP opcode.

@plafer plafer force-pushed the plafer-fix-block-stack-table-respan branch from 1c22be2 to 2a68ec1 Compare October 2, 2024 19:18
@plafer plafer added no changelog This PR does not require an entry in the `CHANGELOG.md` file and removed no changelog This PR does not require an entry in the `CHANGELOG.md` file labels Oct 2, 2024
@plafer plafer force-pushed the plafer-fix-block-stack-table-respan branch 3 times, most recently from 30f0992 to d27600a Compare October 2, 2024 19:25
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@plafer plafer force-pushed the plafer-fix-block-stack-table-respan branch from d27600a to a898596 Compare October 3, 2024 10:43
@plafer plafer merged commit 8d06221 into next Oct 3, 2024
9 checks passed
@plafer plafer deleted the plafer-fix-block-stack-table-respan branch October 3, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants