Fix block stack table respan #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
plafer
force-pushed
the
plafer-fix-block-stack-table-respan
branch
from
1c22be2
to
2a68ec1
Compare
plafer
added
no changelog
plafer
force-pushed
the
plafer-fix-block-stack-table-respan
branch
3 times, most recently
from
30f0992
to
d27600a
Compare
plafer
force-pushed
the
plafer-fix-block-stack-table-respan
branch
from
d27600a
to
a898596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was still a bug after #1511 with how the a
RESPANoperation fetches theis_loopvirtual column of the block stack table.The fix is to set
is_looptoZEROwhen removing a row from aRESPAN, since theis_loopflag (read inhasher_state[5]) only applies to theENDoperation. For requests, it will only be set for theLOOPopcode.