[fix]: VerifyCmd Flag Collision #1513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Oct 18, 2024
Comment on lines
+23
to
24
| #[clap(short = 'x', long = "hash")] | ||
| program_hash: String, |
There was a problem hiding this comment.
I would probably keep the long name as program-hash as it is more self-describing.
Comment on lines
20
to
+21
| #[clap(short = 'p', long = "proof", value_parser)] | ||
| proof_file: PathBuf, | ||
| proof_file: Option<PathBuf>, |
There was a problem hiding this comment.
I would keep proof_file as required and try to infer input/output files based on it (rather than using input file to infer proof/output file).
Comment on lines
+28
to
+33
| pub fn execute(&mut self) -> Result<(), Report> { | ||
|
|
||
| let (proof_file,output_file)=self.infer_defaults(); | ||
|
|
||
| self.proof_file=Some(proof_file); | ||
| self.output_file=Some(output_file); |
There was a problem hiding this comment.
I'm not sure we need to make self mutable here. Once we get the inferred files we can probably use them directly rather than reading them from self.
| @@ -62,4 +69,26 @@ impl VerifyCmd { | |||
|
|
|||
| Ok(()) | |||
| } | |||
| } | |||
|
|
|||
| pub fn infer_defaults(&self)->(PathBuf,PathBuf){ | |||
There was a problem hiding this comment.
As mentioned in another comment, I'd probably infer input/output files based on the proof file rather than the other way around.
Also, I don't think this function needs to be public, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Related #1421
This PR does the following:
program-hashto-x. No long forminfer_defaultsfunction which checks the directory specified by the input file passed(with-i) to search for a.proofand.outputsfile (only if these files are not already specified) . If these files are already specified by user, then it does not run this check.Hence the command can be called as such:
as well as such:
TODO:
Checklist before requesting a review
nextaccording to naming convention.