Implement new hash_memory proc
#1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Oct 1, 2024
bobbinth
reviewed
Oct 1, 2024
Al-Kindi-0
approved these changes
Oct 14, 2024
bobbinth
approved these changes
Oct 15, 2024
| end | ||
| "; | ||
|
|
||
| build_test!(source, &[]).expect_stack(&[0; 4]); |
There was a problem hiding this comment.
Why not test against expected stack [0; 16]?
There was a problem hiding this comment.
My initial thought was to check the actual value which hash_memory_words produces, but we can check the entire stack, the result should be the same.
There was a problem hiding this comment.
Let's check the entire stack - this way we'll be sure that the procedure doesn't "mess" with the rest of the stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR as #1369 needed to re-add this procedure to the
al-migrate-new-padding-rulebranch.