Serialize decorator data at the end #1531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasonk
commented
Oct 13, 2024
| ) -> Self { | ||
| let variant = EncodedDecoratorVariant::from(decorator); | ||
| let decorator_data_offset = |
There was a problem hiding this comment.
Making things a bit more direct. To calculate decorator offset, this used to make a call to an argument passed into this function using two other arguments passed into this function.
yasonk
commented
Oct 13, 2024
| *MAGIC, magic | ||
| ))); | ||
| } | ||
| read_and_validate_magic(source)?; |
There was a problem hiding this comment.
Having a single line of code for each item being read, improves readability of this method
yasonk
force-pushed
the
serialize-decorator-data-at-the-end
branch
from
2ade28c
to
eb59ff3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Moving all decorator data to the end in order to enable truncating it later. See issue #1489
Contains a minor refactor to make writing decorator info more direct by reducing interconnected layers of indirection.
Also extracted some functions from the Serializer code to make it easer follow.
Checklist before requesting a review
nextaccording to naming convention.