Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MastForest merging #1534

Merged
merged 45 commits into from
Oct 28, 2024
Merged

Implement MastForest merging #1534

merged 45 commits into from
Oct 28, 2024

Commits on Oct 25, 2024

  1. feat(core): Move EqHash to core and rename

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    82b90c1 View commit details
    Browse the repository at this point in the history

  2. feat(core): Implement Mast Forest merging

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2f4529b View commit details
    Browse the repository at this point in the history

  3. feat(core): Address clippy lints

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    c431f64 View commit details
    Browse the repository at this point in the history

  4. feat(core): Optimize id mappings with ForestIdMap

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ff15c84 View commit details
    Browse the repository at this point in the history

  5. feat(core): Document code and improve code quality

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    0a1310e View commit details
    Browse the repository at this point in the history

  6. feat(core): Move dfs iterator to its own module

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e83b573 View commit details
    Browse the repository at this point in the history

  7. feat(core): Add documentation

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d2983d6 View commit details
    Browse the repository at this point in the history

  8. fix(core): Dfs iterator on empty forest

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    00109dd View commit details
    Browse the repository at this point in the history

  9. feat(core): Revert MastNodeEq rename

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    bc20663 View commit details
    Browse the repository at this point in the history

  10. chore(core): Simplify and improve structure

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2892036 View commit details
    Browse the repository at this point in the history

  11. chore: Add changelog entry

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    38e048a View commit details
    Browse the repository at this point in the history

  12. fix(core): Use roots of the forest for discovering trees

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    cf7bac8 View commit details
    Browse the repository at this point in the history

  13. feat(core): Rework API and adapt to changed DFS iteration behavior

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    0675413 View commit details
    Browse the repository at this point in the history

  14. feat(core): Add MastForest::iter_nodes

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5ec8eee View commit details
    Browse the repository at this point in the history

  15. chore(core): Move tests to separate file

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    375d36c View commit details
    Browse the repository at this point in the history

  16. feat(core): Implement dedicated external node merging

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9625fc0 View commit details
    Browse the repository at this point in the history

  17. feat(core): Add test cases for external nodes with decorators

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    22efb8c View commit details
    Browse the repository at this point in the history

  18. fix(core): Implement "drop external node" merging behavior

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    4a7e28c View commit details
    Browse the repository at this point in the history

  19. feat(core): Deduplicate external nodes with same MAST root

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5fec6df View commit details
    Browse the repository at this point in the history

  20. feat(core): Make merge impl independent of &self

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2887e74 View commit details
    Browse the repository at this point in the history

  21. chore(core): Update doc comments on iterator

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    62a1d5d View commit details
    Browse the repository at this point in the history

  22. feat(core): Handle invalid decorator indices

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    535c11b View commit details
    Browse the repository at this point in the history

  23. feat(core): Implement MastForestRootMap

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f5e8e97 View commit details
    Browse the repository at this point in the history

  24. chore(core): Update docs to new implementation

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    883f224 View commit details
    Browse the repository at this point in the history

  25. feat(core): Add DecoratorId::new_unsafe constructor

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    c976b4c View commit details
    Browse the repository at this point in the history

  26. chore(core): Make root map pub, fix doc link

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    72e99e5 View commit details
    Browse the repository at this point in the history

  27. feat(assembly): Add assembler-produced forest merge test

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f64b94b View commit details
    Browse the repository at this point in the history

  28. chore(core): Rename dfs_iterator mod

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    462ce59 View commit details
    Browse the repository at this point in the history

  29. chore(core): Change lookup_external_node_by_root param

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9af5a6c View commit details
    Browse the repository at this point in the history

  30. feat(core): Take ownership of merging forests

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    33a4b9c View commit details
    Browse the repository at this point in the history

  31. Revert "feat(core): Take ownership of merging forests" 

    This reverts commit 9394a3a.
    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    56ae0d9 View commit details
    Browse the repository at this point in the history

  32. feat(core): Implement Multi forest iterator

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a761e9f View commit details
    Browse the repository at this point in the history

  33. chore: fix lints and errors

    @bobbinth @PhilippGackstatter
    bobbinth authored and PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5ab8d56 View commit details
    Browse the repository at this point in the history

  34. chore(core): Add missing documentation and cleanup

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d46a073 View commit details
    Browse the repository at this point in the history

  35. chore(core): Use index with fingerprints

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    644fcb0 View commit details
    Browse the repository at this point in the history

  36. feat(core): Move Vec inside the MastForestRootMap

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    617e514 View commit details
    Browse the repository at this point in the history

  37. chore: Address review comments

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    7082f55 View commit details
    Browse the repository at this point in the history

  38. feat(core): Allow unvisited nodes on the iterator stack

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d469149 View commit details
    Browse the repository at this point in the history

  39. feat(core): Add test case for duplicate children

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b4c48d5 View commit details
    Browse the repository at this point in the history

  40. chore(stdlib): Add mast forest merge test

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f09d7f9 View commit details
    Browse the repository at this point in the history

  41. chore(core): Rename to {MastNodeId,DecoratorId}::new_unchecked

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f5a7327 View commit details
    Browse the repository at this point in the history

  42. feat(core): Use a deque instead of a stack in the iterator

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2fbe528 View commit details
    Browse the repository at this point in the history

  43. chore(core): Improve docs and comments

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9d5400f View commit details
    Browse the repository at this point in the history

  44. fix(core): Use VecDeque from alloc instead of std

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    660ad95 View commit details
    Browse the repository at this point in the history

  45. chore(stdlib): Don't clone stdlib forest

    @PhilippGackstatter
    PhilippGackstatter committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    0f76408 View commit details
    Browse the repository at this point in the history