fix: use unchecked constructor for ProcedureName
on Library
deserialization
#1554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Following the conversation with @bitwalker the checked constructor fits only when parsing MASM code. The Miden package contains the export names crafted according to the Wasm CM naming scheme, i.e.
namespace:package/interface@version#function
.Discovered in 0xPolygonMiden/compiler#347 when parsing the Miden package file of the basic wallet account code.
The test for the failing case added in #1544 in the
Package
deserialization test suite atmiden-vm/package/src/tests.rs
Lines 136 to 147 in 9ff342e
Checklist before requesting a review
next
according to naming convention.