Fix block stack table #1557
Open
Fix block stack table #1557
+33
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plafer
force-pushed
the
plafer-fix-block-stack-table
branch
from
8c38d46
to
b79fd13
Compare
bobbinth
approved these changes
Oct 30, 2024
Comment on lines
48
to
+49
| /// Computes the multiplicand representing the removal of a row from the block stack table. | ||
| fn get_block_stack_table_removal_multiplicand<E: FieldElement<BaseField = Felt>>( | ||
| fn get_block_stack_table_respan_multiplicand<E: FieldElement<BaseField = Felt>>( |
There was a problem hiding this comment.
I think the comment here needs to be updated.
Comment on lines
+67
to
+68
|
|
||
| fn get_block_stack_table_end_multiplicand<E: FieldElement<BaseField = Felt>>( |
There was a problem hiding this comment.
Would be good to add a brief comment here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes block stack table (once again).
The problem this time was that the code that removed a row (on
RESPANorEND) would always read theIS_CALLandIS_SYSCALLflags, which are only valid on anENDoperation. The blake3 benchmark happened to have aRESPANoperation with a fewRESPANs that had a1in one of these rows. The fix is then to completely separate these 2 code paths.I confirmed that all
miden-basetest pass.