-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add command to compile libraries #997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left a few comments inline. The main thing is that I'm thinking we should change the command to work more like this:
miden bundle <dir> --version <version> --namespace <namespace>
Where namespace
is optional.
This would force the user to have a different folder per bundle, that is a more constrained version of the command. For example, if there are two versions of the same library, and they share a Should I change? |
5ea0c33
to
a284829
Compare
Not sure I fully followed this: doesn't the command take all MASM files from a given directory? How would a shared directory be specified in this case? (and what namespace in the library hierarchy would it get?) |
My mistake. I had something else in mind. I'm making the requested changes. |
a284829
to
532fa20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I added one commit which fixes a few typos in the docs.
Describe your changes
This adds a CLI command to compile masm files to a masl, useful for CLI users.
Checklist before requesting a review
next
according to naming convention.