Skip to content

Commit

Permalink
AllowanceHolder Use top-level calldata for authentication and avoid P…
Browse files Browse the repository at this point in the history
…ermit2 `ecrecover` and nonce cancellation PRO-73 (#25)

This PR also cleans up some assembly that wasn't safe for 0.8

closes #11
  • Loading branch information
dekz authored Jan 3, 2024
2 parents 6cec0d7 + 103d854 commit 1273617
Show file tree
Hide file tree
Showing 120 changed files with 1,597 additions and 553 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
118980
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
131567
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
121818
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
118981
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
131568
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
121819
1 change: 1 addition & 0 deletions .forge-snapshots/allowanceHolder_uniswapV3_DAI-WETH.snap
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
145213
1 change: 1 addition & 0 deletions .forge-snapshots/allowanceHolder_uniswapV3_USDC-WETH.snap
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
161856
1 change: 1 addition & 0 deletions .forge-snapshots/allowanceHolder_uniswapV3_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
151907
2 changes: 1 addition & 1 deletion .forge-snapshots/curveV2Pool_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
361267
341755
2 changes: 1 addition & 1 deletion .forge-snapshots/curveV2Pool_swapRouter_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
431419
412035
Original file line number Diff line number Diff line change
@@ -1 +1 @@
56852
59314
Original file line number Diff line number Diff line change
@@ -1 +1 @@
58551
60981
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_basic_curve_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
365506
419300
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_curveV2_fee_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
447897
435708
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
129389
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
140380
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
136398
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_metaTxn_otc_DAI-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
99282
102557
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_metaTxn_otc_USDC-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
118756
122031
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_metaTxn_otc_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
110394
113669
Original file line number Diff line number Diff line change
@@ -1 +1 @@
117518
128932
Original file line number Diff line number Diff line change
@@ -1 +1 @@
138456
141498
Original file line number Diff line number Diff line change
@@ -1 +1 @@
128745
131770
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_metaTxn_uniswapV3_DAI-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
143020
154664
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_metaTxn_uniswapV3_USDC-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
167307
171285
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_metaTxn_uniswapV3_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
157696
161357
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_otc_DAI-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
94258
96226
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_otc_USDC-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
113732
115700
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_otc_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
105370
107338
1 change: 0 additions & 1 deletion .forge-snapshots/settler_otc_buyToken_fee_DAI-WETH.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/settler_otc_buyToken_fee_USDC-WETH.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/settler_otc_buyToken_fee_USDT-WETH.snap

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
159816
163124
Original file line number Diff line number Diff line change
@@ -1 +1 @@
182633
186654
Original file line number Diff line number Diff line change
@@ -1 +1 @@
174355
178092

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/settler_otc_sellToken_fee_DAI-WETH.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/settler_otc_sellToken_fee_USDC-WETH.snap

This file was deleted.

1 change: 0 additions & 1 deletion .forge-snapshots/settler_otc_sellToken_fee_USDT-WETH.snap

This file was deleted.

2 changes: 1 addition & 1 deletion .forge-snapshots/settler_uniswapV2_DAI-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
136655
139434
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_uniswapV2_USDC-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
160506
152869
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_uniswapV2_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
153015
145379
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_uniswapV3VIP_DAI-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
113580
122904
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_uniswapV3VIP_USDC-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
134524
135470
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_uniswapV3VIP_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
124829
125742
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_uniswapV3_DAI-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
137092
148576
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_uniswapV3_USDC-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
161379
165198
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_uniswapV3_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
151768
155270
Original file line number Diff line number Diff line change
@@ -1 +1 @@
176952
187066
Original file line number Diff line number Diff line change
@@ -1 +1 @@
201239
203688
Original file line number Diff line number Diff line change
@@ -1 +1 @@
191628
193760
Original file line number Diff line number Diff line change
@@ -1 +1 @@
150345
161393
Original file line number Diff line number Diff line change
@@ -1 +1 @@
171290
173959
Original file line number Diff line number Diff line change
@@ -1 +1 @@
161668
164231
Original file line number Diff line number Diff line change
@@ -1 +1 @@
170883
182003
Original file line number Diff line number Diff line change
@@ -1 +1 @@
197983
202455
Original file line number Diff line number Diff line change
@@ -1 +1 @@
187123
190961
Original file line number Diff line number Diff line change
@@ -1 +1 @@
148518
160806
Original file line number Diff line number Diff line change
@@ -1 +1 @@
176825
181484
Original file line number Diff line number Diff line change
@@ -1 +1 @@
167623
169282
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_zeroExOtc_DAI-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
145780
148326
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_zeroExOtc_USDC-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
174977
177523
2 changes: 1 addition & 1 deletion .forge-snapshots/settler_zeroExOtc_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
160683
163229
2 changes: 1 addition & 1 deletion .forge-snapshots/uniswapRouter_uniswapV3_DAI-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
105467
108571
2 changes: 1 addition & 1 deletion .forge-snapshots/uniswapRouter_uniswapV3_USDC-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
126411
121137
2 changes: 1 addition & 1 deletion .forge-snapshots/uniswapRouter_uniswapV3_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
116522
111250
2 changes: 1 addition & 1 deletion .forge-snapshots/wethDeposit.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
80211
80995
2 changes: 1 addition & 1 deletion .forge-snapshots/wethWithdraw.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
44749
46209
2 changes: 1 addition & 1 deletion .forge-snapshots/zeroEx_curveV2VIP_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
472468
453061
Original file line number Diff line number Diff line change
@@ -1 +1 @@
477450
458014
2 changes: 1 addition & 1 deletion .forge-snapshots/zeroEx_metaTxn_uniswapV3_DAI-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
232579
240893
2 changes: 1 addition & 1 deletion .forge-snapshots/zeroEx_metaTxn_uniswapV3_USDC-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
253523
253459
2 changes: 1 addition & 1 deletion .forge-snapshots/zeroEx_metaTxn_uniswapV3_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
243762
243700
2 changes: 1 addition & 1 deletion .forge-snapshots/zeroEx_otcOrder_DAI-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
93311
93071
2 changes: 1 addition & 1 deletion .forge-snapshots/zeroEx_otcOrder_USDC-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
112785
112545
2 changes: 1 addition & 1 deletion .forge-snapshots/zeroEx_otcOrder_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
104423
104183
2 changes: 1 addition & 1 deletion .forge-snapshots/zeroEx_uniswapV3VIP_DAI-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
104268
112551
2 changes: 1 addition & 1 deletion .forge-snapshots/zeroEx_uniswapV3VIP_USDC-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
125212
125117
2 changes: 1 addition & 1 deletion .forge-snapshots/zeroEx_uniswapV3VIP_USDT-WETH.snap
Original file line number Diff line number Diff line change
@@ -1 +1 @@
115451
115358
Original file line number Diff line number Diff line change
@@ -1 +1 @@
117784
126120
Original file line number Diff line number Diff line change
@@ -1 +1 @@
138713
138686
Original file line number Diff line number Diff line change
@@ -1 +1 @@
128952
128927
Original file line number Diff line number Diff line change
@@ -1 +1 @@
156911
164954
Original file line number Diff line number Diff line change
@@ -1 +1 @@
181478
181468
Original file line number Diff line number Diff line change
@@ -1 +1 @@
169256
169250
Loading

0 comments on commit 1273617

Please sign in to comment.