Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curve Tricrypto factory pools #105

Closed
wants to merge 16 commits into from

Conversation

duncancmt
Copy link
Collaborator

No description provided.

@duncancmt duncancmt requested review from dekz and robpal1990 April 24, 2024 19:28
@duncancmt duncancmt force-pushed the dcmt/curve-tricrypto branch from 771f07c to 6813642 Compare April 24, 2024 19:34
@duncancmt duncancmt self-assigned this Apr 25, 2024
@duncancmt duncancmt changed the title WIP: PoC Curve Tricrypto factory pools VIP Curve Tricrypto factory pools Apr 25, 2024
@duncancmt duncancmt marked this pull request as ready for review April 25, 2024 23:38
Comment on lines +95 to +97
tstore(0x00, isForwarded)
tstore(0x01, mload(add(0x20, permit))) // nonce
tstore(0x02, mload(add(0x40, permit))) // deadline
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No arbitrary callback data, that sucks.

We could pack isForwarded and deadline ?

uint64 factoryNonce = uint64(poolInfo >> 16);
uint8 sellIndex = uint8(poolInfo >> 8);
uint8 buyIndex = uint8(poolInfo);
address pool = curveFactory.deriveContract(factoryNonce);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this over encoded poolAddress + Indexes packed?

@duncancmt
Copy link
Collaborator Author

merged

@duncancmt duncancmt closed this May 16, 2024
@duncancmt duncancmt deleted the dcmt/curve-tricrypto branch May 16, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants