Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_class/get_class_at implemented #126

Merged
merged 75 commits into from
Aug 15, 2023
Merged
Changes from 1 commit
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
6a4418f
Refactoring builder
Jul 12, 2023
24233c7
Make rpc, http required for a builder
Jul 12, 2023
9740039
Raw changes
Jul 13, 2023
3e014a3
Impl file introduced
Jul 13, 2023
909850e
Merge branch 'main' into cases/get_class_impls
Jul 17, 2023
ddf28c3
Some raw changes
Jul 17, 2023
aa39801
Raw changes. Need to keep sierra contracts in Starknet
Jul 17, 2023
9c92dc0
Single starknet impl
Jul 17, 2023
305f9f0
Added sierra contract + tests
Jul 17, 2023
ae81619
Formatted code
Jul 17, 2023
7f04552
Update README.md; trigger CI
FabijanC Jul 18, 2023
526e2b4
Unused error
Jul 18, 2023
99eaefb
Merge branch 'cases/starknet/store_sierra' of github.com:0xSpaceShard…
Jul 18, 2023
70e0479
Merge branch 'main' into cases/starknet/store_sierra
Jul 18, 2023
100ec39
Formatting applied
Jul 18, 2023
a59d02e
Merge branch 'cases/starknet/store_sierra' into cases/get_class_impls
Jul 26, 2023
29c498d
Raw commit
Jul 26, 2023
7563bea
Raw changes with serialization
Jul 27, 2023
36b7dfa
Compiles
Jul 27, 2023
8d82968
Merge branch 'main' into cases/get_class_impls
Jul 27, 2023
4e8ed28
Conflict resolved
Jul 27, 2023
4c1ddd2
Removed FeltHex
Jul 27, 2023
30419ee
Merge pull request #114 from 0xSpaceShard/cases/models-to-types
taco-paco Jul 28, 2023
d23c5c0
Merge branch 'main' into cases/get_class_impls
Aug 1, 2023
93ea518
Compilation fixed
Aug 1, 2023
c6ca44a
Merge branch 'cases/get_class_impls' of github.com:0xSpaceShard/stark…
Aug 1, 2023
e6a7259
Compilation fixed
Aug 1, 2023
9d17b17
Separate serde_helpers until fully migrated
Aug 1, 2023
aa6098f
ContractAddressHex -> ContractAddress
Aug 1, 2023
be6a4c4
ContractAddressHex -> ContractAddress
Aug 1, 2023
bf5daf3
Compilation fixes
Aug 1, 2023
42d47ce
Moved to types
Aug 1, 2023
8d2e152
Formating applied
Aug 1, 2023
3984aff
Merge branch 'cases/ContractAddressHex-To-ContractAddress' into cases…
Aug 1, 2023
2e2bfc1
Conpilation fixes
Aug 1, 2023
4372583
models::ContractClass -> types::ContractClass
Aug 1, 2023
f42aaa7
Compilation fixed after contract_class moved to types.
Aug 1, 2023
cb509c5
models/ContractClass -> types/ContractClass
Aug 3, 2023
66dfdc0
Raw changes
Aug 3, 2023
6695c12
Research DeclareTransactionV1::contract_class possible types
Aug 3, 2023
8ba20de
Compare results main
Aug 4, 2023
70235b9
Test fixes
Aug 7, 2023
ba49cb9
Tests fixed. correct class_hash
Aug 7, 2023
84a4461
get_class_impl done
Aug 7, 2023
450f845
Added some tests
Aug 7, 2023
a1ffb8d
Test fixes
Aug 8, 2023
274c483
Renamed data -> test_data
Aug 8, 2023
aaa917d
Removed test compilation warnings
Aug 8, 2023
a007274
Merge branch 'main' into cases/get_class_impls
Aug 8, 2023
373f4cb
Fix merge conflicts + clippy compilation fixes
Aug 8, 2023
df9602a
Merge branch 'main' into cases/ContractAddressHex-To-ContractAddress
Aug 8, 2023
be80d68
Clippy compilation fixes
Aug 8, 2023
e8385fd
Fixed pr comment
Aug 8, 2023
ecbb598
Merge branch 'cases/ContractAddressHex-To-ContractAddress' into cases…
Aug 8, 2023
63215de
Removed serde_helpers from starknet-server
Aug 8, 2023
5bc56fe
Stylistic edits
Aug 8, 2023
36f9ced
Convert ContracClass to codegen ContractClass
Aug 9, 2023
6c8df45
Follow up
Aug 9, 2023
648f94c
Cherry-picked from refactoring branch
Aug 13, 2023
f2854c0
Tests passed. Serialization fixed
Aug 13, 2023
f0ea419
Deleted sierra
Aug 13, 2023
50e3684
Added test + some cleaning
Aug 13, 2023
e2a363a
Fixed conversion to CodegenSierraClass
Aug 14, 2023
edc734a
Merge branch 'cases/merge/get_class_impls' into cases/get_class_impls
Aug 14, 2023
8230661
Merge branch 'main' into cases/get_class_impls
Aug 14, 2023
f3475f5
Compilation + some test fixes after merge
Aug 14, 2023
9a7488a
Formatting applied + clippy fixes
Aug 14, 2023
09cf010
Revert fmt changes + formatting applied
Aug 14, 2023
c7f1c9d
Remove mut access
Aug 14, 2023
0fff809
Deleted contract_class.rs from modules
Aug 14, 2023
a93bd40
Revert changes
Aug 14, 2023
b3066c8
Pr fixes
Aug 15, 2023
1e9eb4a
Removed old errors
Aug 15, 2023
3c789dd
Moved empty params into starknet-server
Aug 15, 2023
7ad9187
Get class impls ci (#131)
marioiordanov Aug 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed pr comment
edwin committed Aug 8, 2023
commit e8385fd090bf3964d0047a96d6dea5968747d4b5
2 changes: 1 addition & 1 deletion crates/starknet-server/src/api/json_rpc/mod.rs
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@ pub mod error;
mod models;
mod write_endpoints;

use crate::api::serde_helpers::empty_params;
use models::{
BlockAndClassHashInput, BlockAndContractAddressInput, BlockAndIndexInput, CallInput,
EstimateFeeInput, EventsInput, GetStorageInput, TransactionHashInput,
@@ -11,7 +12,6 @@ use serde::{Deserialize, Serialize};
use server::rpc_core::error::RpcError;
use server::rpc_core::response::ResponseResult;
use server::rpc_handler::RpcHandler;
use starknet_types::serde_helpers::empty_params;
use tracing::{error, info, trace};

use self::error::ApiError;
19 changes: 19 additions & 0 deletions crates/starknet-server/src/api/serde_helpers.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,22 @@
/// A module that deserializes `[]` optionally
pub mod empty_params {
use serde::{Deserialize, Deserializer};

pub fn deserialize<'de, D>(d: D) -> Result<(), D::Error>
where
D: Deserializer<'de>,
{
let seq = Option::<Vec<()>>::deserialize(d)?.unwrap_or_default();
if !seq.is_empty() {
return Err(serde::de::Error::custom(format!(
"expected params sequence with length 0 but got {}",
seq.len()
)));
}
Ok(())
}
}

pub mod base_64_gzipped_json_string {
use base64::Engine;
use serde::{Deserialize, Deserializer};
19 changes: 0 additions & 19 deletions crates/types/src/serde_helpers.rs
marioiordanov marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,22 +1,3 @@
/// A module that deserializes `[]` optionally
pub mod empty_params {
use serde::{Deserialize, Deserializer};

pub fn deserialize<'de, D>(d: D) -> Result<(), D::Error>
where
D: Deserializer<'de>,
{
let seq = Option::<Vec<()>>::deserialize(d)?.unwrap_or_default();
if !seq.is_empty() {
return Err(serde::de::Error::custom(format!(
"expected params sequence with length 0 but got {}",
seq.len()
)));
}
Ok(())
}
}

pub mod rpc_sierra_contract_class_to_sierra_contract_class {
use serde::{Deserialize, Deserializer};