Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starknet api todo #446

Closed

Conversation

Gerson2102
Copy link

Usage related changes

Development related changes

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • [ TODO comments for removal #327 ] Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

@Gerson2102
Copy link
Author

Gerson2102 commented Apr 25, 2024

I changed the value of this to ContractClass:

RawJson(Cairo0Json), Rpc(ContractClass),

And i can handle it better than changing the value of the Rawjson. But i have errors with the changes i made. Is not clear to me which one i have to change.

@ivpavici ivpavici requested a review from marioiordanov April 26, 2024 09:43
Copy link
Contributor

@marioiordanov marioiordanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea is to change the value of RawJson variant from Cairo0Json to starknet_api::deprecated_contract_class::ContractClass. Then rename the variant from RawJson to StarknetApi

@Gerson2102 Gerson2102 closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants