Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional padding to left of accidentals #1038

Merged
merged 1 commit into from
Jun 26, 2021

Conversation

AaronDavidNewman
Copy link
Collaborator

@AaronDavidNewman AaronDavidNewman commented Jun 14, 2021

I thought it made sense to do the actual formatting changes first, b/c it's hard to evaluate the success of an estimate if there are formatting issues.

This just adds 2 pixels of padding to an accidental block, so they don't get squished against the notes to the left. Also moved a couple of formatting magic numbers to metrics.

Before:
pr-accidental-padding

After, 1px padding:
image

After, 2px padding (this PR):
image

@sschmidTU
Copy link
Contributor

sschmidTU commented Jun 15, 2021

Nice!
Can the padding be modified though? That would be great. I can see myself prefering only 1 pixel of padding (if at all), to keep scores more compact. Every pixel counts ;)
(also, did you try 1 pixel left padding? wasn't it enough?)

@AaronDavidNewman
Copy link
Collaborator Author

@sschmidTU it is a metric of the font, so I'd image you can override it at a score/application level.
I also included 1 px as a reference.

@0xfe
Copy link
Owner

0xfe commented Jun 26, 2021

Looks good, thanks!

@0xfe 0xfe merged commit 51aac32 into 0xfe:master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants