feat: ini v3 core #210
Open
feat: ini v3 core #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attente
force-pushed
the
v3-core
branch
2 times, most recently
from
86d26f3 to
56c6f8a
Compare
…onfiguration consistency
…age hash calculation This commit modifies the CreateAnypaySapientSignerTree function to replace the attestation signer address with a specific address (0x0000000000000000000000000000000000000001) for the image hash calculation. This change ensures that the function operates with a valid address, improving the reliability of the signer tree creation process within the intent configuration.
…n signer address This commit modifies the intent configuration tests to replace hardcoded addresses with a dynamic attestation signer address (0x0000000000000000000000000000000000000001). The changes ensure that the tests accurately reflect the current implementation and improve the reliability of the signer tree creation process. Additionally, the CreateAnypaySapientSignerTree function is updated to utilize the attestation signer parameter, enhancing flexibility in address handling.
…iable names This commit introduces debug logging using the spew package to output the configuration tree and signature details during the intent configuration process. Additionally, it refactors variable names in the CreateIntentTree function for clarity, changing 'sapientSignerLeaf' to 'sapientSignerLeafNode' to better represent its purpose. These changes enhance the debugging capabilities and readability of the code.
…Tree This commit introduces the `replaceSapientSignerWithNodeInConfigTree` function, which recursively traverses the WalletConfigTree and replaces any sapient signer leaves with node leaves. Additionally, the `GetIntentConfigurationSignature` function is updated to call this new function when a sapient signer is detected in the configuration, enhancing the handling of signer types in the intent configuration process.
…gner with node leaf This commit simplifies the logic in the GetIntentConfigurationSignature function by ensuring that the sapient signer is always replaced with a node leaf in the configuration tree when the target payload is nil. This change enhances the consistency of the intent configuration process.
…GetIntentConfigurationSignature logic This commit expands the functionality of the replaceSapientSignerWithNodeInConfigTree function to handle both WalletConfigTreeNode and WalletConfigTreeNestedLeaf types, ensuring proper recursive replacement of sapient signer leaves. Additionally, the GetIntentConfigurationSignature function is updated to conditionally apply this replacement logic based on the presence of lifiInfos and attestationSigner, improving the handling of intent configurations.
…ure handling in GetIntentConfigurationSignature
…o reflect new values
…ions for consistency in intent configuration handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes all required core
configuration,imageHash,signaturemodules derived from sequence-core forv3and ensures that all critical tests are passing.Steps to test
rpc:Caveats
Some gas-estimation commands, etc. are commented out because of the scope of this PR. will follow up in a later PR. Also,
Permission,SmartSession,SessionManagerrelated modules will follow up later.