Skip to content

Fix simulation immutable #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix simulation immutable #232

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b6cc2ee
replace code on wallet implementation address
nachopiris Mar 17, 2025
82da1b4
fix
nachopiris Mar 18, 2025
d3b4f4c
check implementation address not in overrides
nachopiris Mar 18, 2025
9f4c4a0
fix last added condition
nachopiris Mar 18, 2025
53d82c1
last fix
nachopiris Mar 18, 2025
7269ee4
remove comment
nachopiris Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions estimator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,19 +603,34 @@ func V2Simulate(provider *ethrpc.Provider, wallet common.Address, transactions T
Data: hexutil.Encode(callData),
}

addrToOverride := wallet

var storageValue string
rpcCall := ethrpc.NewCallBuilder[string]("eth_getStorageAt", nil, wallet.Hex(), common.BytesToHash(common.LeftPadBytes(wallet.Bytes(), 32)).Hex(), block)
_, err = provider.Do(context.Background(), rpcCall.Into(&storageValue))
if err != nil {
return nil, err
}

impAddr := common.BytesToAddress(common.FromHex(storageValue)[12:])

if impAddr != (common.Address{}) {
addrToOverride = impAddr
}

allOverrides := map[common.Address]*CallOverride{
wallet: {Code: walletGasEstimatorCodeV2},
addrToOverride: {Code: walletGasEstimatorCodeV2},
}
for address, override := range overrides {
if address == wallet {
return nil, fmt.Errorf("cannot override wallet address %v", wallet.Hex())
if address == addrToOverride || address == wallet {
return nil, fmt.Errorf("cannot override wallet or implementation address %v", addrToOverride.Hex())
}

allOverrides[address] = override
}

var response string
rpcCall := ethrpc.NewCallBuilder[string]("eth_call", nil, params, block, allOverrides)
rpcCall = ethrpc.NewCallBuilder[string]("eth_call", nil, params, block, allOverrides)
_, err = provider.Do(context.Background(), rpcCall.Into(&response))
if err != nil {
return nil, err
Expand Down
Loading