feat: auto prefix message with EIP191 if not prefixed #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VGabriel45
changed the title
tolgahan-arikan
approved these changes
Mar 7, 2025
taylanpince
force-pushed
the
feat/account_signMessage_auto_prefix
branch
from
f8101d8 to
3581a00
Compare
Dargon789
added a commit
to Dargon789/sequence.js
that referenced
this pull request
Mar 13, 2025
* Revert "[AUTOMATED] Update constants.ts (0xsequence#681)" This reverts commit a181b69. * [AUTOMATED] Update files from 0xsequence/stack (0xsequence#680) * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts --------- Co-authored-by: pkieltyka <[email protected]> Co-authored-by: nachopiris <[email protected]> Co-authored-by: VojtechVitek <[email protected]> Co-authored-by: david-littlefarmer <[email protected]> * [AUTOMATED] Update files from 0xsequence/marketplace-api (0xsequence#682) * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts --------- Co-authored-by: david-littlefarmer <[email protected]> Co-authored-by: VojtechVitek <[email protected]> Co-authored-by: AlexanderKolberg <[email protected]> * [AUTOMATED] Update: proto/clients/metadata.gen.ts (0xsequence#684) Co-authored-by: VojtechVitek <[email protected]> * [AUTOMATED] Update: proto/clients/relayer.gen.ts (0xsequence#685) Co-authored-by: VojtechVitek <[email protected]> * [AUTOMATED] Update: proto/clients/guard.gen.ts (0xsequence#686) Co-authored-by: VojtechVitek <[email protected]> * feat: auto prefix message with EIP191 if not prefixed (0xsequence#689) * feat: add auto prefixing check to account.signMessage * refactor: refactor logic to use ethers method * [AUTOMATED] Update: api/proto/clients/api.gen.ts (0xsequence#690) Co-authored-by: taylanpince <[email protected]> --------- Co-authored-by: 0xsequence-bot <[email protected]> Co-authored-by: pkieltyka <[email protected]> Co-authored-by: nachopiris <[email protected]> Co-authored-by: VojtechVitek <[email protected]> Co-authored-by: david-littlefarmer <[email protected]> Co-authored-by: AlexanderKolberg <[email protected]> Co-authored-by: Gabi <[email protected]> Co-authored-by: taylanpince <[email protected]>
Dargon789
added a commit
to Dargon789/sequence.js
that referenced
this pull request
Mar 13, 2025
* Revert "[AUTOMATED] Update constants.ts (0xsequence#681)" This reverts commit a181b69. * [AUTOMATED] Update files from 0xsequence/stack (0xsequence#680) * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts * [AUTOMATED] Update: api/proto/clients/api.gen.ts --------- * [AUTOMATED] Update files from 0xsequence/marketplace-api (0xsequence#682) * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts * [AUTOMATED] Update: proto/clients/marketplace.gen.ts --------- * [AUTOMATED] Update: proto/clients/metadata.gen.ts (0xsequence#684) * [AUTOMATED] Update: proto/clients/relayer.gen.ts (0xsequence#685) * [AUTOMATED] Update: proto/clients/guard.gen.ts (0xsequence#686) * feat: auto prefix message with EIP191 if not prefixed (0xsequence#689) * feat: add auto prefixing check to account.signMessage * refactor: refactor logic to use ethers method * [AUTOMATED] Update: api/proto/clients/api.gen.ts (0xsequence#690) --------- Co-authored-by: 0xsequence-bot <[email protected]> Co-authored-by: pkieltyka <[email protected]> Co-authored-by: nachopiris <[email protected]> Co-authored-by: VojtechVitek <[email protected]> Co-authored-by: david-littlefarmer <[email protected]> Co-authored-by: AlexanderKolberg <[email protected]> Co-authored-by: Gabi <[email protected]> Co-authored-by: taylanpince <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the DX for @0xsequence/account and @0xsequence/auth, messages are now prefixed by default in the SDK with EIP191 if not prefixed already.