Skip to content

Add session signature decoding #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 6, 2025
Merged

Add session signature decoding #886

merged 5 commits into from
Oct 6, 2025

Conversation

ScreamingHawk
Copy link
Contributor

Also renames encodeSessionCallSignatures to more accurate encodeSessionSignature

@ScreamingHawk ScreamingHawk requested review from a team as code owners October 2, 2025 02:38
patrislav
patrislav approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@patrislav patrislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the degree that I can review it, looks good! I'd only suggest to turn these magic numbers into descriptive consts and a short comment to explain some ternaries

@ScreamingHawk ScreamingHawk merged commit d2329ab into master Oct 6, 2025
3 checks passed
@ScreamingHawk ScreamingHawk deleted the decodeSessionSignature branch October 6, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrislav patrislav patrislav approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ScreamingHawk @patrislav