Use project ID from header #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkieltyka
reviewed
Mar 13, 2024
| @@ -68,7 +69,7 @@ func TestRPC_SendIntent_SendTransaction(t *testing.T) { | |||
|
|
|||
| c := proto.NewWaasAuthenticatorClient(srv.URL, http.DefaultClient) | |||
| header := make(http.Header) | |||
| header.Set("X-Access-Key", newRandAccessKey(tenant.ProjectID)) | |||
| header.Set("X-Sequence-Project", strconv.Itoa(int(tenant.ProjectID))) | |||
There was a problem hiding this comment.
hmm, what is X-Sequence-Project....? I dont remember, is that a thing..?
There was a problem hiding this comment.
the ingress proxy parses the access key (as it uses quotacontrol) and passes it to waas-authenticator in the X-Sequence-Project header - this is already in place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ingress proxy already uses quotacontrol and passes the project ID in the
X-Sequence-Projectheader.Because of the change in how v2 access keys are generated, we'd need to bring quotacontrol as dependency just for extracting the project ID from the key. And instead, we can do that by utilizing the header we already receive.
Closes https://github.com/0xsequence/issue-tracker/issues/1983