WIP: EIP-4337 Support through hooks #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScreamingHawk
force-pushed
the
eip-4337
branch
from
86371b3
to
ce7c2de
Compare
|
We should be moving in the direction of an EOA guard anyway, that's what WaaS uses and it would also be good for the universal wallet (more secure). |
Agusx1211
reviewed
Sep 11, 2023
contracts/hooks/EIP4337Hook.sol
Outdated
| */ | ||
| function eip4337SelfExecute(IModuleCalls.Transaction[] calldata txs) external payable onlyEntrypoint { | ||
| // Self execute | ||
| (bool success, ) = payable(address(this)).call{value: msg.value}( |
There was a problem hiding this comment.
FYI native .call copies return data into memory even if you don't define it. Either use LibOptim.call or use the returned data directly.
Agusx1211
reviewed
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an implementation of EIP-4337 that can be added as a hook.
Support is only valid (due to opcode restrictions) when the tx signature doesn't validate against nested Sequence wallets (due to accessing imageHash on the nested wallet and potentially GAS op code usage).
This means signatures including the guard will fail. A temporary solution could be adding an EOA based guard or increasing the threshold of the session key.