clearing errors on a field with data-validate=“false” upon .validator…

…(‘update’). refs #387
1000hz · Dec 8, 2016 · 7004d07 · 7004d07
1 parent 2f49477
commit 7004d07
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/js/tests/unit/validator.js b/js/tests/unit/validator.js
@@ -603,6 +603,11 @@ $(function () {
     assert.equal($('#validated').text(), 'error', 'validation of skipped field was forced due to data-validate="true"')
     assert.equal($('#skipped').text(), '', 'validation of field was bypassed due to data-validate="false"')
 
+    $('[data-validate="true"]').attr('data-validate', false)
+    form.validator('update')
+
+    assert.equal($('#validated').text(), '', 'error is cleared when data-validate="false" and the form is updated')
+
     $.fn.validator.Constructor.INPUT_SELECTOR = inputSelector
   })
 

diff --git a/js/validator.js b/js/validator.js
@@ -110,9 +110,13 @@
   }
 
   Validator.prototype.update = function () {
+    var self = this
+
     this.$inputs = this.$element.find(Validator.INPUT_SELECTOR)
       .add(this.$element.find('[data-validate="true"]'))
-      .not(this.$element.find('[data-validate="false"]'))
+      .not(this.$element.find('[data-validate="false"]')
+        .each(function () { self.clearErrors($(this)) })
+      )
 
     this.toggleSubmit()