[FEATURE] Ajout de la possibilité * comme paramètre (PIX-15594) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://api-data-pr59.review.pix.fr |
Gudsfile
changed the title
Gudsfile
changed the title
sandalfon
force-pushed
the
feature-add-wildcard-for-queryparams
branch
2 times, most recently
from
7088801 to
c510662
Compare
sandalfon
force-pushed
the
feature-add-wildcard-for-queryparams
branch
from
c510662 to
890df7f
Compare
HEYGUL
reviewed
Dec 9, 2024
HEYGUL
reviewed
Dec 9, 2024
HEYGUL
reviewed
Dec 9, 2024
HEYGUL
reviewed
Dec 9, 2024
HEYGUL
reviewed
Dec 10, 2024
sandalfon
force-pushed
the
feature-add-wildcard-for-queryparams
branch
2 times, most recently
from
69622ad to
488602f
Compare
pix-service-auto-merge
force-pushed
the
feature-add-wildcard-for-queryparams
branch
from
488602f to
6083e88
Compare
Steph0
reviewed
Dec 11, 2024
sandalfon
force-pushed
the
feature-add-wildcard-for-queryparams
branch
from
6083e88 to
8824dd9
Compare
Je reformule si on prend le numéro de département en paramètre c'est un entier |
Comment on lines
296
to
332
| it('should return a proper error with status code 403', async function () { | ||
| // given | ||
| const queryId = '26f6efcc-ce13-4b20-b6ea-5bebae6115af'; | ||
|
|
||
| await knexAPI('catalog_queries').insert({ | ||
| id: queryId, | ||
| sql_query: `SELECT COUNT(*) as count FROM public.data_ref_academies where nom = {{ academie }}`, | ||
| name: 'foo', | ||
| }); | ||
| await knexAPI('query_access').insert({ | ||
| query_id: queryId, | ||
| user_id: userId, | ||
| }); | ||
| await knexAPI('catalog_query_params').insert({ | ||
| id: 1, | ||
| catalog_query_id: queryId, | ||
| name: 'academie', | ||
| type: 'string', | ||
| mandatory: true, | ||
| }); | ||
| await knexAPI('query_param_access').insert({ | ||
| id: queryId, | ||
| user_id: userId, | ||
| query_param_id: 1, | ||
| value: 'Bordeaux', | ||
| }); | ||
|
|
||
| const payload = { | ||
| queryId, | ||
| params: <UserCommandParam[]>[{ name: 'academie', value: 'Paris' }], | ||
| }; | ||
|
|
||
| // when | ||
| const server = await createServer(); | ||
| const response = await server.inject({ | ||
| method: 'POST', |
There was a problem hiding this comment.
Ce test correspond au test d'avant, on peut le supprimer je pense
VincentHardouin
force-pushed
the
feature-add-wildcard-for-queryparams
branch
from
8824dd9 to
ade8efd
Compare
VincentHardouin
approved these changes
Dec 16, 2024
VincentHardouin
added
🚀 Ready to Merge
Tech Review OK
and removed
👀 Tech Review Needed
labels
Signed-off-by: Gilles Vieira <[email protected]>
pix-service-auto-merge
force-pushed
the
feature-add-wildcard-for-queryparams
branch
from
ade8efd to
3f8619e
Compare
pix-service-auto-merge
deleted the
feature-add-wildcard-for-queryparams
branch
pix-service-auto-merge
pushed a commit
that referenced
this pull request
Dec 16, 2024
# [0.11.0](v0.10.2...v0.11.0) (2024-12-16) ### 🚀 Amélioration - [#59](#59) Ajout de la possibilité * comme paramètre (PIX-15594) ### 🏗️ Tech - [#63](#63) Proposition de modifications pour le setup de developement
|
🎉 This PR is included in version 0.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
aujourd'hui les paramètres doivent avoir leur valeur définie, pour parcoursup il faut requeter sur différents id non connu à l'avance
🎁 Proposition
ajout du * comme valeur wildecard
🧦 Remarques
🚨cela fonctionne pour * donc un string, actuellement rien n'est prévu si le paramètre est un numérique, pas sur que la bd accepte * en valeur
🎅 Pour tester